Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Docusaurus v3 upgrades and require TypeScript 5 #9258

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 25, 2023

Breaking change

TypeScript 5 is now required for Docusaurus v3

Motivation

Handle #9050 (review), use these settings for client code packaging:

    "moduleResolution": "bundler",
    "module": "esnext",

"bundler" is a new TS 5.0 option: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#moduleresolution-bundler

This also fix our setup for TypeScript 5.2 because this version introduces new errors that makes it impossible to:

Test Plan

CI

Deploy preview: https://deploy-preview-9258--docusaurus-2.netlify.app/

@slorber slorber added the pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. label Aug 25, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 25, 2023
@slorber slorber added this to the 3.0 milestone Aug 25, 2023
@netlify
Copy link

netlify bot commented Aug 25, 2023

[V2]

Name Link
🔨 Latest commit ebbfbd3
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64e863ee7722160008caf4d9
😎 Deploy Preview https://deploy-preview-9258--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 67 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 81 🟢 98 🟢 92 🟢 100 🟠 89 Report

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Aug 25, 2023
@argos-ci
Copy link

argos-ci bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 2 changes Aug 25, 2023, 8:30 AM

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 117 kB
website/build/assets/css/styles.********.css 113 kB
website/build/assets/js/main.********.js 837 kB
website/build/index.html 41.3 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: breaking change Existing sites may not build successfully in the new version. Description contains more details.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants