Add support for Web App Manifest in siteConfig #934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To improve user experience and low load time for re-visiting users, I would like to include a service worker to make it a Progressive Web App. Adding service worker is easy with
scripts
in siteConfig but one would require manifest.json to be able to add it to the home screen. With the current code base, there is no extra field to add manifest.json to the head.Thus have added an optional field
manifest
in siteConfig and update thelib/core/Head.js
along withdocs/api-site-config.md
accordingly.Test Plan
Well as the code implies if the config key exists then create the
<link />
tag accordingly. No special test cases are required.