-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update node engine version 18 #9348
Conversation
Hi @OzakIOne! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart the examples modification that should be reverted.
CI will tell us if it works fine
- [Node.js](https://nodejs.org/en/download/) version 16.14 or above: | ||
- [Node.js](https://nodejs.org/en/download/) version 18.0 or above: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples are generated with a script and are used to populate stackblitz/codesandbox templates.
They should represent the stable version of Docusaurus and shouldn't be updated manually.
These example changes should be reverted because examples are still using Docusaurus v2 (which supports Node 16.14)
They are basically new sites initialized with npx create-docusaurus@latest
, so if you modify create-docusaurus
these will be self-updated on next regeneration after a stable release. We don't have examples for unstable/next/alpha/beta/rc/canary versions.
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Breaking change
Docusaurus v3 drops support for Node 16 (end-of-life September 2023) and now requires Node.js >= 18.0
Motivation
Require Node.js >= 18
As discussed in the related issue, node 16 is EOL since 11 September 2023
Test Plan
CI
Test links
https://deploy-preview-9348--docusaurus-2.netlify.app/
Related issues/PRs
#7455 (comment)