Prettify all JavaScript files #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit ad840b9 |
endiliey
approved these changes
Sep 17, 2018
|
@endiliey Thanks for the reminder. I also removed the |
gustavohenke
reviewed
Nov 5, 2018
| @@ -5,5 +5,5 @@ | |||
| "printWidth": 80, | |||
| "proseWrap": "never", | |||
| "singleQuote": true, | |||
| "trailingComma": "es5" | |||
| "trailingComma": "all" | |||
There was a problem hiding this comment.
This broke Node 6 support (LTS until April 2019) 🙃
But I assume my CI file could be tweaked to not build docs on all supported versions...
https://github.com/express-validator/express-validator/blob/b4f0c256d281fb917b59221f4bfa93c2d81cd91a/.travis.yml
There was a problem hiding this comment.
My apologies. We did mention that Docusaurus requires Node 8 and above: https://docusaurus.io/docs/en/installation#installing-docusaurus
gustavohenke
added a commit
to express-validator/express-validator
that referenced
this pull request
Nov 5, 2018
TigerStar429
pushed a commit
to TigerStar429/expressjs-validator
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enable Prettier for v2 files. I took the opportunity to clean up all the prettier commands into one since we don't run them separately anyway. Also, use a
**/*.jspattern to just run on every file. We have no use case for not running Prettier on any directory for now.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI.
Related PRs
NA.