-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Docusaurus 1 files into directory #966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions:
- The test fails on CI. Might need to fix it first.
- Why are we removing Open Collective ? That's the only reminder to user 😭
Kinda like the monorepo move, somewhat similar to jest
monorepo
@endiliey I have fixed the tests. See if they're ok. I found the OC message spammy and I thought it was a bad idea to make users download an entire project just to show one message. I could add it back 🤣 The Netlify preview is failing because of the changed path, which I will fix after this PR gets merged. |
Haha, I think we can remove it since it downloads an entire package for that. Maybe we can be evil 😈 in the future and modify the Docusaurus CLI message such that it will show the Open Collective message and only stop if your email is registered as contributor. 🔥 🔥🔥🔥🔥🔥🔥🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine I guess. But we might need to adjust the netlify since it fails ?
Feel free to merge whenever you're ready |
Thanks, please help to test it if possible 😄 |
Upon investigation: We should not delete this,
Then there is no
|
My bad, the removal wasn't intentional. Will add it back. |
Motivation
Better separation of projects.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
yarn lint
andyarn prettier
commands pass.Related PRs
NA
Next Steps