Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Docusaurus 1 files into directory #966

Merged
merged 4 commits into from
Sep 17, 2018
Merged

Move Docusaurus 1 files into directory #966

merged 4 commits into from
Sep 17, 2018

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Sep 17, 2018

Motivation

Better separation of projects.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  1. Run site locally and navigate around.
  2. Build site locally and load using local webserver.
  3. yarn lint and yarn prettier commands pass.
  4. Test via CI.

Related PRs

NA

Next Steps

  • Fix Netlify preview path
  • Set up CI for v2

@yangshun yangshun requested a review from endiliey September 17, 2018 14:29
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 17, 2018
Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions:

  1. The test fails on CI. Might need to fix it first.
  2. Why are we removing Open Collective ? That's the only reminder to user 😭

Kinda like the monorepo move, somewhat similar to jest monorepo

@endiliey endiliey requested a review from JoelMarcey September 17, 2018 15:29
@yangshun
Copy link
Contributor Author

yangshun commented Sep 17, 2018

@endiliey I have fixed the tests. See if they're ok.

I found the OC message spammy and I thought it was a bad idea to make users download an entire project just to show one message. I could add it back 🤣

The Netlify preview is failing because of the changed path, which I will fix after this PR gets merged.

@endiliey
Copy link
Contributor

Haha, I think we can remove it since it downloads an entire package for that.

Maybe we can be evil 😈 in the future and modify the Docusaurus CLI message such that it will show the Open Collective message and only stop if your email is registered as contributor. 🔥 🔥🔥🔥🔥🔥🔥🔥

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine I guess. But we might need to adjust the netlify since it fails ?

@endiliey
Copy link
Contributor

Feel free to merge whenever you're ready

@yangshun yangshun merged commit f2927a9 into master Sep 17, 2018
@yangshun
Copy link
Contributor Author

Thanks, please help to test it if possible 😄

@yangshun yangshun deleted the monorepo branch September 17, 2018 16:58
@endiliey
Copy link
Contributor

Upon investigation:

We should not delete this,
Since this is what triggers husky

// package.json
"precommit": "lint-staged"

Then there is no lint command in root directory package.json

`"linters": {
      "{v1,v2}/**/*.js": ["yarn lint --fix", "yarn prettier", "git add"]
    }

@yangshun
Copy link
Contributor Author

My bad, the removal wasn't intentional. Will add it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants