-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swizzle): ask user preferred language if no language CLI option provided #9681
feat(swizzle): ask user preferred language if no language CLI option provided #9681
Conversation
Hi @yixiaojiu! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thanks, LGTM 👍 This will be in v3.2 I refactored a bit, deduplicating the prompting util extracted in #9442 Also:
|
Fail-fast if user uses --typescript option with a theme that does not support TS
Pre-flight checklist
Motivation
Following the issue #9402, I created a prompt that just shows up when neither
--javascript
or--typescript
is passedfix #9402
Usage screenshot
Related issues/PRs
#9402