Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename v2 project back to Docusaurus #975

Merged
merged 3 commits into from
Sep 21, 2018
Merged

chore: rename v2 project back to Docusaurus #975

merged 3 commits into from
Sep 21, 2018

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Sep 21, 2018 •
edited
Loading

Motivation

  • Better v2 log
  • Change munseo or endiliey to docusaurus

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 21, 2018
@endiliey endiliey changed the title [WIP] Docusaurus 2 Alpha 🔥 [WIP] Docusaurus 2 Alpha Sep 21, 2018
@docusaurus-bot

This comment has been minimized.

Sign in to view
@endiliey endiliey added status: don't merge yet This PR is completed, but we are still waiting for other things to be ready. work in progress labels Sep 21, 2018
yangshun
yangshun approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR contents should be an issue on its own we can use to track the progress instead.

Otherwise LGTM! Feel free to self-merge.

@endiliey
Copy link
Contributor Author

Hmm true. We should create an issue for it instead inside a PR.

@endiliey

This comment has been minimized.

Sign in to view
@endiliey endiliey changed the title [WIP] Docusaurus 2 Alpha feat: rename v2 project back to Docusaurus Sep 21, 2018
@endiliey endiliey removed status: don't merge yet This PR is completed, but we are still waiting for other things to be ready. work in progress labels Sep 21, 2018
@endiliey endiliey changed the title feat: rename v2 project back to Docusaurus chore: rename v2 project back to Docusaurus Sep 21, 2018
@endiliey endiliey merged commit fbdd799 into master Sep 21, 2018
@endiliey endiliey deleted the v2 branch September 21, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

Assignees

@yangshun yangshun

@endiliey endiliey

Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@endiliey @docusaurus-bot @yangshun @facebook-github-bot