Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: GitHub actions deployment should use fetch-depth: 0 + actions upgrades #9759

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jan 18, 2024

Motivation

Not having fetch-depth: 0 will lead to a bad "docs last update" date being rendered.

Also upgrading documented actions to newer versions

Fix #2798

https://deploy-preview-9759--docusaurus-2.netlify.app/docs/deployment#triggering-deployment-with-github-actions

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 18, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 18, 2024
Copy link

netlify bot commented Jan 18, 2024

[V2]

Name Link
🔨 Latest commit 321509c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65a900ea3755920008162346
😎 Deploy Preview https://deploy-preview-9759--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 43 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 85 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 68 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 62 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 89 Report

Copy link

Size Change: 0 B

Total Size: 985 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 75 kB
website/build/assets/css/styles.********.css 114 kB
website/build/assets/js/main.********.js 758 kB
website/build/index.html 37.9 kB

compressed-size-action

@slorber slorber merged commit 0469590 into main Jan 18, 2024
12 checks passed
@slorber slorber deleted the slorber/gh-fetch-depth-docs branch January 18, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last updated on time / author is always same for every page?
2 participants