-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(core): optimize broken links checker #9778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: bug fix
This PR fixes a bug in a past release.
and removed
CLA Signed
Signed Facebook CLA
labels
Jan 22, 2024
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
changed the title
pref(core)): optimize broken links checker
pref(core): optimize broken links checker
Jan 22, 2024
slorber
added
pr: performance
This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient.
to backport
This PR is planned to be backported to a stable version of Docusaurus
and removed
pr: bug fix
This PR fixes a bug in a past release.
labels
Jan 22, 2024
Size Change: 0 B Total Size: 986 kB ℹ️ View Unchanged
|
7 tasks
slorber
changed the title
pref(core): optimize broken links checker
perf(core): optimize broken links checker
Jan 22, 2024
1 task
slorber
added a commit
that referenced
this pull request
Jan 26, 2024
7 tasks
This was referenced May 19, 2024
This was referenced Jun 27, 2024
This was referenced Jul 17, 2024
This was referenced Jul 21, 2024
This was referenced Jul 21, 2024
This was referenced Aug 4, 2024
This was referenced Aug 12, 2024
This was referenced Aug 21, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: performance
This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient.
to backport
This PR is planned to be backported to a stable version of Docusaurus
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #9754
The new logic added for the broken anchor link checker made the algorithm slow for large sites with many routes and links.
This PR optimizes the algo:
matchRoutes(routes,pathname)
callsTest Plan
CI + unit tests
Considering this site/commit: harness/developer-hub@d5d1311
Upgrading to Docusaurus v3.1 leads the broken link checker to take 5 minutes. After this PR it only takes 1 second.
Another site reporting significant build time improvements:
#9754 (comment)