-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: optimize getFileCommitDate, make it async #9890
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: performance
This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient.
to backport
This PR is planned to be backported to a stable version of Docusaurus
labels
Feb 24, 2024
slorber
added
the
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
label
Feb 24, 2024
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Size Change: 0 B Total Size: 992 kB ℹ️ View Unchanged
|
Josh-Cena
approved these changes
Feb 24, 2024
OzakIOne
pushed a commit
that referenced
this pull request
Feb 28, 2024
This was referenced May 19, 2024
This was referenced May 26, 2024
This was referenced Aug 4, 2024
This was referenced Aug 12, 2024
This was referenced Aug 15, 2024
This was referenced Aug 21, 2024
This was referenced Aug 27, 2024
This was referenced Sep 4, 2024
This was referenced Sep 8, 2024
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
CLA Signed
Signed Facebook CLA
pr: performance
This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient.
to backport
This PR is planned to be backported to a stable version of Docusaurus
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
getFileCommitDate()
has been identified as a strong sync IO bottleneck of theloadContent
blog and docs lifecycle hooks.Making it async greatly optimizes the time it takes to call
loadContent
on all plugins. This only affects the production build becausegetFileCommitDate()
was already bypassed in dev mode.Local benchmark
yarn clear:website && yarn build:website --locale en
Before:
loadContent
: 17sAfter: 🔥
loadContent
: 1.2sTest Plan
unit tests + CI
Test links
https://deploy-preview-9890--docusaurus-2.netlify.app/