-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sitemap): add support for "lastmod" #9954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove now useless /404.html edge case handling
slorber
added
pr: new feature
This PR adds a new API or behavior.
to backport
This PR is planned to be backported to a stable version of Docusaurus
labels
Mar 15, 2024
3 tasks
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: +45 B (0%) Total Size: 992 kB
ℹ️ View Unchanged
|
…orber/sitemap-lastmod
Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent work; I like that you're looking to make the default sitemap include lastmod
by default with Docusaurus v4
pmarschik
reviewed
Mar 19, 2024
This was referenced Aug 21, 2024
This was referenced Aug 27, 2024
This was referenced Sep 4, 2024
This was referenced Sep 8, 2024
This was referenced Sep 11, 2024
This was referenced Sep 28, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: new feature
This PR adds a new API or behavior.
to backport
This PR is planned to be backported to a stable version of Docusaurus
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #2604
Add new sitemap options:
lastmod
that permits to output<lastmod>
tags in the sitemap, formatted asYYYY-MM-DD
date, or ISO datetime<changefreq>
and<priority>
sitemap tags (Google doesn't use them) withnull
valuesImportant notes:
lastmod
only works for routes backed and requires plugin authors to add new route metadata when callingaddRoute()
<lastmod>
tag for React page components as well. However it will only use the React page source Git history, and will not check history of its dependencies.<lastmod>
tag. If a third-party plugin does not provide the new metadata, the sitemap can't infer a proper value. According to Google recommendations, it's only relevant to use<lastmod>
tags for routes backed by content, and not routes aggregating multiple documents (tags, blog pagination, blog archive, doc autogenerated index...)Test Plan
Unit tests + dogfood on our website
Test links
Related issues/PRs
Supersed PR #9234