-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(website): organise blog posts by year #9965
Conversation
Hi @GingerGeek! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super fan of this new option, and wonder if we really need it?
What prevents you from adopting this FS structure?
According to what I see, it works out of the box, see sandbox:
https://stackblitz.com/edit/github-8ukygb
We support multiple date extraction patterns allowing you to group by year, month and/or day:
https://docusaurus.io/docs/next/blog#blog-post-date
However I agree that we should group our blog posts by year so if you want to keep your website blog post refactor in this PR, I'm open to merge it without introducing the new option.
packages/docusaurus-plugin-content-blog/src/plugin-content-blog.d.ts
Outdated
Show resolved
Hide resolved
c6f31d3
to
53490ad
Compare
Yeap agreed with your comments here, clearly I should read docs better! I have kept the refactor for blog locations and removed the new option |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks 👍
Pre-flight checklist
Motivation
The blogs folder has grown over time and it would be useful to organise it by year.
Test Plan
Test links
Deploy preview: https://deploy-preview-9965--docusaurus-2.netlify.app/
Related issues/PRs