Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): improve dev perf, fine-grained site reloads - part2 #9968

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 20, 2024

Motivation

This is a follow-up of the DX improvements started in #9903

The goal of this is to improve the dev experience performance.

Previously if you edited a docs/intro.mdx file, all the plugins lifecycle contentLoaded() would run.

Now, when editing a doc file, only the doc plugin instance contentLoaded() lifecycle will run, preventing useless expensive calls and IOs on other unrelated plugins.

Test Plan

Unit tests + dogfood

Test links

https://deploy-preview-9968--docusaurus-2.netlify.app/

Related issues/PRs

This is possible thanks to the introducing of a new allContentLoaded() lifecycle in #9931

Unlike contentLoaded(), this lifecycle has to re-run whenever any plugin content change. Thankfully, many plugins (including our 3 content plugins) do not have to implement this lifecycle.

@slorber slorber requested a review from Josh-Cena as a code owner March 20, 2024 18:51
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 20, 2024
@slorber slorber added pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient. to backport This PR is planned to be backported to a stable version of Docusaurus Argos Add this label to run UI visual regression tests. See argos.yml GH action. and removed CLA Signed Signed Facebook CLA labels Mar 20, 2024
Copy link

netlify bot commented Mar 20, 2024

[V2]

Name Link
🔨 Latest commit 73f6efe
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65fc1f32804edc00083ab05f
😎 Deploy Preview https://deploy-preview-9968--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 20, 2024
Copy link

github-actions bot commented Mar 20, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 43 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 63 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 53 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 63 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 71 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

github-actions bot commented Mar 20, 2024

Size Change: 0 B

Total Size: 992 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 75.4 kB
website/build/assets/css/styles.********.css 114 kB
website/build/assets/js/main.********.js 765 kB
website/build/index.html 37.9 kB

compressed-size-action

Copy link

argos-ci bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Mar 21, 2024, 11:59 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient. to backport This PR is planned to be backported to a stable version of Docusaurus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants