-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(utils): remove duplicated function #9972
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: +1.41 kB (0%) Total Size: 994 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addPrefix/removePrefix/addSuffix/removeSuffix (+ tests) should all move to utils-common stringUtils.ts
in a consistent way.
If utils use these methods, you can add a dependency from util to util-common (but not the opposite)
Motivation
Avoid duplication of code
Test Plan
jest, ci, lint
Test links
Deploy preview: https://deploy-preview-9972--docusaurus-2.netlify.app/
Related issues/PRs
#9949