Release statically linked executables on Linux #34
Conversation
One of the major benefits of dotslash is to be used to bootstrap other tools on pretty much any system. Unfortunately when it comes to linux the executables included in the release are built on Ubuntu 22.04 which means that they link a fairly modern GLIBC. Trying to use the executable on an older Ubuntu (or any other flavor of Linux that doesn't use GLIBC) will fail due to linking errors. We could instead build the binary on a super old linux version but Github only goes back to 20.04 so instead let's produce a fully static executable that statically link the musl libc. This is a common pattern that many tools built for linux adopt and it will greatly simplify the adoption on linux distros that don't repackage dotslash.
|
Hi @ddeville! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
I feel like not including musl was just an oversight in the first place, so hopefully this is not controversial @zertosh? I see buck2 also does musl releases: https://github.com/facebook/buck2/releases |
|
👍 |
|
@zertosh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
One of the major benefits of dotslash is to be used to bootstrap other tools on pretty much any system. Unfortunately when it comes to linux the executables included in the release are built on Ubuntu 22.04 which means that they link a fairly modern glibc. Trying to use the executable on an older Ubuntu (or any other flavor of Linux that doesn't use glibc) will fail due to linking errors.
We could instead build the binary on a super old linux version but Github only goes back to 20.04 so instead let's produce a fully static executable that statically links the musl libc.
This is a common pattern that many tools built for linux adopt and it will greatly simplify the adoption on linux distros that don't repackage dotslash.