fix nullpointer exception in UserSettingsManager

Summary: crash reported when response is null setting it to the fallback value instead of crashing out Reviewed By: YOUDAN, KylinChang Differential Revision: D13815342 fbshipit-source-id: 6f58911ab38b7a9c38a614eb10a3f1bda069c4cd
facebook · Jan 25, 2019 · 66d9c62 · 66d9c62
1 parent dff7f22
commit 66d9c62
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/facebook-core/src/main/java/com/facebook/UserSettingsManager.java b/facebook-core/src/main/java/com/facebook/UserSettingsManager.java
@@ -144,10 +144,12 @@ public void run() {
                             codelessRequest.setSkipClientToken(true);
                             codelessRequest.setParameters(codelessSettingsParams);
                             JSONObject response = codelessRequest.executeAndWait().getJSONObject();
-                            codelessSetupEnabled.value =
-                                    response.optBoolean(EVENTS_CODELESS_SETUP_ENABLED, false);
-                            codelessSetupEnabled.lastTS = currTime;
-                            writeSettingToCache(codelessSetupEnabled);
+                            if (response != null) {
+                              codelessSetupEnabled.value =
+                                      response.optBoolean(EVENTS_CODELESS_SETUP_ENABLED, false);
+                              codelessSetupEnabled.lastTS = currTime;
+                              writeSettingToCache(codelessSetupEnabled);
+                            }
                         }
                     }
                 }