Skip to content

Commit

Permalink
remove uninstall token upload request
Browse files Browse the repository at this point in the history
Summary:
1. Since we already attach device token when we send events, we can deprecate uninstall token upload request.
2. Remove outdated comments in coffeeshop
3. Hold this diff until device token aggregated pipeline is launched.

Reviewed By: codytwinton

Differential Revision: D13717727

fbshipit-source-id: 494d3c62d38f699b3f994d58f8ab7bad854af330
  • Loading branch information
KylinChang authored and codytwinton committed Jan 17, 2019
1 parent 6e6865e commit 937788f
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions FBSDKCoreKit/FBSDKCoreKit/FBSDKAppEvents.m
Original file line number Diff line number Diff line change
Expand Up @@ -659,23 +659,6 @@ + (void)setPushNotificationsDeviceTokenString:(NSString *)deviceTokenString
if ([FBSDKAppEvents flushBehavior] != FBSDKAppEventsFlushBehaviorExplicitOnly) {
[[FBSDKAppEvents singleton] flushForReason:FBSDKAppEventsFlushReasonEagerlyFlushingEvent];
}

// Update device push token for uninstall tracking
[FBSDKServerConfigurationManager loadServerConfigurationWithCompletionBlock:^(FBSDKServerConfiguration *serverConfiguration, NSError *error) {
if (serverConfiguration.uninstallTrackingEnabled) {
FBSDKGraphRequest *request = [[FBSDKGraphRequest alloc]
initWithGraphPath:[NSString stringWithFormat:@"%@/%@",
[FBSDKSettings appID], UNINSTALL_TRACKING_TOKEN_ENDPOINT]
parameters:@{
UNINSTALL_TRACKING_DEVICE_TOKEN_KEY: deviceTokenString,
UNINSTALL_TRACKING_PLATFORM_KEY: @"ios",
// advertiserID could be 0s if user select limit ad tracking
UNINSTALL_TRACKING_DEVICE_ID_KEY: [FBSDKAppEventsUtility advertiserID] ?: @""
}
HTTPMethod:@"POST"];
[request startWithCompletionHandler:nil];
}
}];
}
}

Expand Down

0 comments on commit 937788f

Please sign in to comment.