Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS via SPM issues (no FBAEMKit library, no FBSDKTVOSKit) #1936

Closed
5 tasks done
drdaz opened this issue Nov 9, 2021 · 4 comments
Closed
5 tasks done

tvOS via SPM issues (no FBAEMKit library, no FBSDKTVOSKit) #1936

drdaz opened this issue Nov 9, 2021 · 4 comments
Milestone

Comments

@drdaz
Copy link

drdaz commented Nov 9, 2021

Checklist before submitting a bug report

Xcode version

13.1

Facebook iOS SDK version

12.1.0

Dependency Manager

SPM

SDK Framework

Core

Goals

I help maintain the Parse iOS SDK. I'm looking to use SPM for our dependencies on the FB SDK. These are FBSDKCoreKit, FBDSKCoreKit_Basics, FBSDKTVOSKit.

Expected results

Including libs via SPM gives me access to the corresponding library's functionality within my app, across all platforms.

For example, including the FacebookCore dependency should get me access to the FBSDKCoreKit features in my project.

Actual results

All libraries fail to build on tvOS. There seems to be a dependency on FBAEMKit, and FBAEMKit doesn't seem to build for tvOS via SPM.

I don't see any equivalent for FBSDKTVOSKit to add via SPM either.

Screenshot 2021-11-09 at 21 06 49

Screenshot 2021-11-09 at 21 08 02

Steps to reproduce

  1. Make a new tvOS project
  2. Add the 12.1.0 release as an SPM dependency
  3. Add FacebookCore as a project dependency
  4. Build the project
@jawwad
Copy link
Contributor

jawwad commented Dec 10, 2021

Hi @drdaz - Sorry about the late response on this, and we really appreciate the detailed writeup and screenshots on this. @joesus has updated FBAEMKit so that it can be compiled with tvOS. We just released v12.2.1. Can you see if this fixes the issue for you?

@drdaz
Copy link
Author

drdaz commented Dec 10, 2021

Hey @jawwad thanks for that. This release seems to add the FBAEMKit as you describe, but I still don't see any way of adding FBSDKTVOSKit via SPM.

@jsivanes
Copy link

Hello I have the same issue about FKSDKTVOSKIT, can't found it as module, I used the v12.3.1 on Xcode 13.2.1.
Any solution plz?

facebook-github-bot pushed a commit that referenced this issue Feb 23, 2022
Summary: Resolve [GitHub issue #1936](#1936)

Reviewed By: jawwad

Differential Revision: D34400429

fbshipit-source-id: a887906baa185b4a62e6952b7bab4059711d5235
facebook-github-bot pushed a commit that referenced this issue Feb 23, 2022
Summary: Resolve [GitHub issue #1936](#1936)

Reviewed By: jawwad

Differential Revision: D34400429

fbshipit-source-id: 253723c4dc55125d66eec2290ddde10bfed407c2
@samodom
Copy link
Contributor

samodom commented Feb 23, 2022

@jsivanes We are publishing TVOSKit in the v13 release via SPM. After the release (coming very shortly), please give it a shot. If you run into problems at that point, please open another issue specifically referring to that framework's availability.

@samodom samodom closed this as completed Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants