Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Submodules Schemes #839

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Updating Submodules Schemes #839

merged 1 commit into from
Sep 7, 2016

Conversation

thertzelle
Copy link

carthage update on any Facebook-SDK for iOS Development causes a timeout when checking out the dependancies for facebook-ios-sdk

Many companies restrict using the git:// scheme due to it using a specific port and not using proper authorization. Https is much more secure and more commonly unblocked.

Proposing this file be standardized to use https instead of both git and https schemes.

This fixes the carthage update timeout issue.

Alternatively users cloning this project will need to run a command similar to:

git config --global url."https://".insteadOf git://

or remove --global and do it on a project-to-project basis.

carthage update on any Facebook-SDK for iOS Development causes a timeout when checking out the dependancies for facebook-ios-sdk

Many companies restrict using the git:// scheme due to it using a specific port and not using proper authorization. Https is much more secure and more commonly unblocked.

Proposing this file be standardized to use https instead of both git and https schemes.

This fixes the carthage update timeout issue.

Alternatively users cloning this project will need to run a command similar to:

git config --global url."https://".insteadOf git://

or remove --global and do it on a project-to-project basis.
@ghost
Copy link

ghost commented Aug 31, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost
Copy link

ghost commented Aug 31, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@nlutsenko
Copy link
Member

cc @chrisp-fb. This blocks Carthage installation on Swift SDK, since some folks might have git scheme blocked. Since all of the submodules are public - it's fair to simply use https scheme for checkouts, as it's preferred way of adding submodules on GitHub.

@ghost ghost added the CLA Signed label Aug 31, 2016
@chrisp-fb chrisp-fb merged commit bb95452 into facebook:dev Sep 7, 2016
@chrisp-fb
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants