fix: allow babel-eslint 9 and eslint 5 #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimenB I guess it needs a release, right? I'll do that on Monday :) |
|
Yes please! Btw, any reason for https://github.com/facebook/jest/tree/master/packages/eslint-config-fb-strict to live in Jest? If we want those rules in Jest, we should just add it to the config in that repo. If we do want to keep the package, shouldn't it live in this repo? |
|
@mjesun ping 😀 |
|
Released! |
|
woo! I'll update in Jest, we should avoid the peer dep warnings EDIT: jestjs/jest@3c39c40 warning-free install, woo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No breaking changes from the perspective of this package