Use codegen in struct's operator== (redo)

Reviewed By: thedavekwon Differential Revision: D49178168 fbshipit-source-id: dffc03926534df3513d5d5f9baf11fee93329551
facebook · Sep 15, 2023 · a0e7fe5 · a0e7fe5
1 parent a46bb81
commit a0e7fe5
Show file tree

Hide file tree

Showing 66 changed files with 341 additions and 5,275 deletions.
diff --git a/thrift/compiler/generate/templates/cpp2/module_types_cpp/eq_overload.mustache b/thrift/compiler/generate/templates/cpp2/module_types_cpp/eq_overload.mustache
@@ -16,15 +16,5 @@
 
 %>
 bool <%struct:cpp_underlying_name%>::operator==(FOLLY_MAYBE_UNUSED const <%struct:cpp_underlying_name%>& rhs) const {
-  FOLLY_MAYBE_UNUSED auto& lhs = *this;
-<%#struct:fields%><%#field:type%>
-<%#field:lazy?%>
-  lhs.<%field:cpp_name%>_ref();
-  rhs.<%field:cpp_name%>_ref();
-<%/field:lazy?%>
-  if (<% > field/neq%>) {
-    return false;
-  }
-<%/field:type%><%/struct:fields%>
-  return true;
+  return ::apache::thrift::op::detail::StructEquality{}(*this, rhs);
 }
diff --git a/thrift/compiler/test/fixtures/adapter/gen-cpp2/module_types.cpp b/thrift/compiler/test/fixtures/adapter/gen-cpp2/module_types.cpp
diff --git a/thrift/compiler/test/fixtures/any/gen-cpp2/module_types.cpp b/thrift/compiler/test/fixtures/any/gen-cpp2/module_types.cpp
diff --git a/thrift/compiler/test/fixtures/basic-annotations/gen-cpp2/module_types.cpp b/thrift/compiler/test/fixtures/basic-annotations/gen-cpp2/module_types.cpp
diff --git a/thrift/compiler/test/fixtures/basic-enum/gen-cpp2/module_types.cpp b/thrift/compiler/test/fixtures/basic-enum/gen-cpp2/module_types.cpp
diff --git a/thrift/compiler/test/fixtures/basic-stack-arguments/gen-cpp2/module_types.cpp b/thrift/compiler/test/fixtures/basic-stack-arguments/gen-cpp2/module_types.cpp
diff --git a/thrift/compiler/test/fixtures/basic-structured-annotations/gen-cpp2/module_types.cpp b/thrift/compiler/test/fixtures/basic-structured-annotations/gen-cpp2/module_types.cpp
diff --git a/thrift/compiler/test/fixtures/basic/gen-cpp2/module_types.cpp b/thrift/compiler/test/fixtures/basic/gen-cpp2/module_types.cpp