This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 957
Bump OpenSSL-Universal pod dependency to 1.1.171 #1735
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Dec 2, 2020
Pull Request Test Coverage Report for Build 396010412
💛 - Coveralls |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
brentvatne
added a commit
to expo/expo
that referenced
this pull request
Dec 3, 2020
…release target. Related: facebook/flipper#1735
brentvatne
added a commit
to expo/expo
that referenced
this pull request
Dec 3, 2020
…release target. Related: facebook/flipper#1735
I was able to use the updated pod in react-native via: use_flipper!('Flipper-Folly' => { :podspec => 'https://raw.githubusercontent.com/facebook/flipper/master/iOS/Podspecs/Flipper-Folly.podspec' } ) If you don't use react-native, something like this should work: pod 'Flipper-Folly', :podspec => 'https://raw.githubusercontent.com/facebook/flipper/master/iOS/Podspecs/Flipper-Folly.podspec' |
Seems that this fix doesn't take care of the problem entirely. Running into #1758 now - same problem, but a different pod. |
byCedric
pushed a commit
to expo/expo
that referenced
this pull request
Dec 14, 2020
…release target. Related: facebook/flipper#1735
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should fix the react-native issue with building on Xcode 12: facebook/react-native#29984
Changelog
Upgrade OpenSSL-Universal dependency on the one that includes arm for iPhone Simulator: https://github.com/krzyzanowskim/OpenSSL/releases
Test Plan
This PR is not intended to be merged directly, as more version bumping and propagation through the other pods will be needed.