Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fix license issue in CircleCI #362

Closed
wants to merge 1 commit into from
Closed

Properly fix license issue in CircleCI #362

wants to merge 1 commit into from

Conversation

pavlospt
Copy link
Contributor

Apparently this seems to be the only way to make build work, with the updated licenses. It also follows the same strategy as Travis.

I am using double pipe in sdkmanager command execution, to avoid breaking the build, because sdkmanager returns exit code 141 in case it meets the requirements requested. (e.g.: yes | sdkmanager --licenses returns 141, which in turn breaks the build due to set -eo pipefail Bash flags, that CircleCI is using in order to execute any scripts)

For the record, I tried the following solutions, that did not work:

  • Add accepted license SHA in Android SDK licenses folder.
  • Accept all licenses prior to running the other jobs (with a separate job, working as a dependency to the rest of the Workflow jobs) (yes | sdkmanager --licenses)
  • Accept all licenses prior to executing any Gradle command (without a separate job) (yes | sdkmanager --licenses)

Apparently this seems to be the only way to make build work, with
the updated licenses. It also follows the same strategy as Travis.
@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. import started labels Jan 22, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@passy is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@passy
Copy link
Member

passy commented Jan 25, 2019

Thank you, Pavlos! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. import started
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants