private fields and flow-bin@0.90.0 #7355
Labels
Comments
|
Thanks for reporting! |
|
Hi @ilyaztsv! Could you please share your |
|
@pakoito - it's in the shared repository |
facebook-github-bot
pushed a commit
that referenced
this issue
Jan 16, 2019
…te fields Summary: This diff prevents an exception reported in #7355 that'll cause Flow 0.9.0 to always except on private fields. The fix is in place until we fully understand whether private properties are part of the generated signature or not. This diff needs to be followed up in T39206072 after the release. Reviewed By: panagosg7 Differential Revision: D13695528 fbshipit-source-id: 3c4ece37f8bc31da79c8c29ab365070270915756
|
A fix is ready and will be shipped in 0.91, which is releasing this week. |
jbrown215
pushed a commit
that referenced
this issue
Jan 17, 2019
…te fields Summary: This diff prevents an exception reported in #7355 that'll cause Flow 0.9.0 to always except on private fields. The fix is in place until we fully understand whether private properties are part of the generated signature or not. This diff needs to be followed up in T39206072 after the release. Reviewed By: panagosg7 Differential Revision: D13695528 fbshipit-source-id: 731378f3e364b8930ce8b7e80b98faa5d90836b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unfortunately, I was not able to reproduce the issue using https://flow.org/try
I've created the following repository: https://github.com/ilyaztsv/flow-0.90-private-fields
Please see README.md which describes how to reproduce the issue.
flow-bind@0.90.0breaks using of private fields and I have the following error:flow-bind@0.89.0works as expected in my case.Probably, it's related to my PC and environment. Let me know if you need more detailed information.
The text was updated successfully, but these errors were encountered: