Flow 0.97 LSP causes most code to be marked as uncovered, even if the server reports (correctly) that it's 100% covered

[lxe]

Update:

Issue was introduced in 313d6c7

---

Tracking in flow-for-vscode as well: flow/flow-for-vscode#332

Some LSP-related change between 0.96 and 0.97 causes VSCode listening to flow-bin/flow-osx-v0.97.0/flow lsp --from vscode to mark most code as uncovered:

With flowtype.flow-for-vscode-1.1.1 :

Observe that the task bar shows coverage 100%, but every line is marked as uncovered.

Flow 0.96 does not cause flow-for-vscode to exhibit this behavior:

[lxe]

v0.96.0...v0.97.0 bet it's something to do with trusted types

[lxe]

Looks like 3801a02 - v0.96.0 (3 weeks ago) <avik@fb.com> is not the same as flow-bin@0.96.0, as this problem also happens there, but flow-bin@0.96.0 is working fine.

[lxe]

This issue appeared in this commit: 313d6c7

cc @dsainati1

[dsainati1]

Hmmmm. Is this limited to VSCode?

[lxe]

I tried with

[options]
trust_mode=none

trust_mode=check

trust_mode=silent

With no difference

[lxe]

Hmmmm. Is this limited to VSCode?

@dsainati1 I haven't tried any other editor or plugin. I guess maybe the flow lsp extension needs to update to take 313d6c7#diff-84d0c6a799d463d1e58a368fdfb53bf5L1009 into the account

[dsainati1]

I can reproduce with my editor. I think this has to do with the fact that I left trust-coverage mode off for the LSP's persistent coverage command, but I suppose that didn't have the effect I thought it did. Unsure why our tests didn't catch this, but I can fix it for the 0.98 release of Flow.

[lxe]

Thanks @dsainati1

I'm trying to debug the flow-for-vscode side of things. Getting coveredPercent 100 with a bunch of uncoveredRanges

{
  "coveredPercent": 100,
  "uncoveredRanges": [
    {
      "range": {
        "start": {
          "line": 8,
          "character": 7
        },
        "end": {
          "line": 8,
          "character": 15
        }
      }
    },
    ...
  ],
  "defaultMessage": "Un-type checked code. Consider adding type annotations."
}

[dsainati1]

Problem is this line: 313d6c7#diff-84d0c6a799d463d1e58a368fdfb53bf5R1024

No idea how our tests didn't catch this. Thanks for the bug report!

[dsainati1]

Cool I have a fix for this. Should land by Monday and make it into the next release.

[vicapow]

Thanks for the quick fix!

[lxe]

Nice! Thank you!