Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node util module #145

Merged
merged 2 commits into from
Dec 19, 2014
Merged

add node util module #145

merged 2 commits into from
Dec 19, 2014

Conversation

rsolomo
Copy link
Contributor

@rsolomo rsolomo commented Nov 28, 2014

This is based off of the documentation at http://nodejs.org/docs/v0.11.14/api/util.html.
Deprecated APIs mentioned there have been left out for now.

This is based off of the documentation at http://nodejs.org/docs/v0.11.14/api/util.html.
Deprecated APIs mentioned there have been left out for now.
declare function log(string: string): void;
declare function inspect(object: any, options?: {
showHidden?: boolean;
depth?: number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think depth should be ?number since you can pass in null to make it recurse indefinitely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'll update that.

@gabelevi
Copy link
Contributor

Ok, looks good with the small fix! If people need support for earlier APIs I suppose that can be added later

@rsolomo
Copy link
Contributor Author

rsolomo commented Dec 16, 2014

The fix has been made.

@gabelevi
Copy link
Contributor

Cool, thanks!

gabelevi added a commit that referenced this pull request Dec 19, 2014
@gabelevi gabelevi merged commit 5676791 into facebook:master Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants