New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match string variables with literal information in oneOf proptype #318

Closed

samwgoldman wants to merge 1 commit into facebook:master from samwgoldman:oneOf_string_variables

Member

samwgoldman commented Mar 12, 2015

This could be way off-base, but it seems like we'll often have literal information with a StrT. This makes oneOf a lot more powerful/useful.


          Match string variables with literal information in oneOf proptype

763410f

Member Author

samwgoldman commented Mar 13, 2015

This change isn't as foolproof as I'd hoped.

var s = "hello";
var f = () => React.createClass({ propTypes: { s: React.PropTypes.oneOf([s]) } });
s = "oops";
f() // runtime check and static type disagree

samwgoldman closed this

samwgoldman mentioned this pull request

Detect single-assignment bindings #482

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet