Carry on even if there is no TERM environment variable set. #3305
Conversation
There are a few continuous integration systems which act as STDOUT is a
TTY, but don't set `TERM`. On those occasions, we get the following
error message:
Fatal error: exception Not_found
This, obviously, makes it pretty hard to figure out what the actual
problem is. An alternative implementation could throw a better error,
but it felt like defaulting to `"dumb"` was a reasonable solution here.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
nice catch, thanks! there's a |
|
@gabelevi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Thanks for merging this, @mroch! Incidentally, debugging this would have been much easier if the release version of Flow was compiled with debugging symbols. It doesn't move noticeably slower with them switched on in my experience. Is there a reason we couldn't have them turned on all the time? |
Summary:
There are a few continuous integration systems which act as STDOUT is a
TTY, but don't set `TERM`. On those occasions, we get the following
error message:
Fatal error: exception Not_found
This, obviously, makes it pretty hard to figure out what the actual
problem is. An alternative implementation could throw a better error,
but it felt like defaulting to `"dumb"` was a reasonable solution here.
I couldn't see a reasonable place to put tests, so I omitted them. If there
is, please let me know.
Closes #3305
Differential Revision: D4486056
Pulled By: mroch
fbshipit-source-id: 8c55b8eae407eed72f610ce9313745d150235046
There are a few continuous integration systems which act as STDOUT is a
TTY, but don't set
TERM. On those occasions, we get the followingerror message:
This, obviously, makes it pretty hard to figure out what the actual
problem is. An alternative implementation could throw a better error,
but it felt like defaulting to
"dumb"was a reasonable solution here.I couldn't see a reasonable place to put tests, so I omitted them. If there
is, please let me know.