-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Builtin declaration merging #7919
base: main
Are you sure you want to change the base?
Conversation
Nice! |
Not really, I'm not sure this is right way to do this, but it works at least |
@goodmind any plans to eventually add declaration merging for |
@kevinbarabash I'm not even sure if I'm implementing it right way, still wait on review from Flow team |
@kevinbarabash just implemented Also you can't do augmentation in the same file, Flow would complain about re-declaring identifier The thing you lose with this implementation is ability to completely override class with your own types, it would always merge them into original one Also you can't really do anything with merging |
I noticed you added |
Ah, because I was working on top of my |
Somewhat (
sometimes) working fix for #396