Allow mixed args to String.prototype.concat()
#8729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, I'm happy to fix the test failures and to add more tests, but before digging into that work I'd like to get some guidance from maintainers about whether this PR is welcome or not. |
This was referenced Aug 16, 2021
justingrant
force-pushed
the
patch-1
branch
3 times, most recently
from
4f6e2dd to
395f120
Compare
According to MDN docs for the `concat()` method of the `String` type: > If the arguments are not of the type string, they are converted to string > values before concatenating. Passing numbers, objects, etc to `String.prototype.concat` is is valid JS behavior but currently causes an error in Flow. It also may be blocking facebook/react#22064. This commit changes the arg type: `Array<string>` -> `Array<mixed>`.
|
Hi, Justin. I left a comment on the linked React PR, since the context around that change serves as motivation for this one, and just to keep the dialog in one spot. |
|
Looks like this PR isn't aligned with Flow's goals around avoiding implicit type casts, so I'll close this PR to keep the noise of everyone's plate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8728 and unblocks facebook/react#22064.
According to the MDN docs for the
concat()method of theStringbuilt-in type:Passing numbers, objects, etc to
String.prototype.concatis is valid JS behavior but causes an error in Flow. It's also blocking facebook/react#22064.This PR changes the arg type from
Array<string>toArray<mixed>.