Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support glog 0.7.0 #2171

Open
chenrui333 opened this issue Apr 4, 2024 · 2 comments · May be fixed by #2320
Open

Support glog 0.7.0 #2171

chenrui333 opened this issue Apr 4, 2024 · 2 comments · May be fixed by #2320

Comments

@chenrui333
Copy link

👋 trying to build fizz with glog 0.7.0, but ran into some regression test failure as below:

  ==> /usr/bin/clang++ -std=c++17 test.cpp -o test -I/opt/homebrew/Cellar/fizz/2024.04.01.00_1/include -I/opt/homebrew/opt/openssl@3/include -L/opt/homebrew/Cellar/fizz/2024.04.01.00_1/lib -lfizz -L/opt/homebrew/opt/folly/lib -lfolly -L/opt/homebrew/opt/gflags/lib -lgflags -L/opt/homebrew/opt/glog/lib -lglog -L/opt/homebrew/opt/libevent/lib -levent -L/opt/homebrew/opt/libsodium/lib -lsodium -L/opt/homebrew/opt/openssl@3/lib -lcrypto -lssl
  In file included from test.cpp:1:
  In file included from /opt/homebrew/Cellar/fizz/2024.04.01.00_1/include/fizz/client/AsyncFizzClient.h:11:
  In file included from /opt/homebrew/Cellar/fizz/2024.04.01.00_1/include/fizz/client/ClientExtensions.h:11:
  In file included from /opt/homebrew/Cellar/fizz/2024.04.01.00_1/include/fizz/record/Types.h:12:
  In file included from /opt/homebrew/include/folly/io/Cursor.h:31:
  In file included from /opt/homebrew/include/folly/io/IOBuf.h:33:
  /opt/homebrew/include/glog/logging.h:60:4: error: <glog/logging.h> was not included correctly. See the documention for how to consume the library.
  #  error <glog/logging.h> was not included correctly. See the documention for how to consume the library.
     ^

same failure seen for wangle as well.

relates to Homebrew/homebrew-core#163094
@jj683 jj683 mentioned this issue Jun 6, 2024
Merged
@nh2
Copy link
Contributor

nh2 commented Jun 23, 2024

Looks like Arch Linux AUR has a fix for this:

https://aur.archlinux.org/cgit/aur.git/tree/fix-cmake-find-glog.patch?h=folly

@nh2 nh2 mentioned this issue Jun 23, 2024
Closed
@nh2
Copy link
Contributor

nh2 commented Jun 23, 2024

With PR #2245 and the above mentioned AUR patch, folly builds with glog 0.7.1 on NixOS.

This was referenced Jun 23, 2024
Draft
Open
facebook-github-bot pushed a commit to facebook/hhvm that referenced this issue Jul 16, 2024
@nh2 @facebook-github-bot
symbolizer: Fix missing unistd.h include.
eba4a12 
Summary:
Fixes `close`/`lseek`/`read`/`pread` not being in scope.

It only worked so far because `#include <glog/logging.h>` apparently brought them into scope; with glog >= 0.7.0 that does not work anymore.

See also facebook/folly#2171 (comment)

X-link: facebook/folly#2245

Reviewed By: Gownta

Differential Revision: D58968225

Pulled By: Orvid

fbshipit-source-id: fe9b4ba3d08e910b60225d3ed6b17a314655dfe4
facebook-github-bot pushed a commit that referenced this issue Jul 16, 2024
@nh2 @facebook-github-bot
symbolizer: Fix missing unistd.h include. (#2245)
af86faa 
Summary:
Fixes `close`/`lseek`/`read`/`pread` not being in scope.

It only worked so far because `#include <glog/logging.h>` apparently brought them into scope; with glog >= 0.7.0 that does not work anymore.

See also #2171 (comment)

Pull Request resolved: #2245

Reviewed By: Gownta

Differential Revision: D58968225

Pulled By: Orvid

fbshipit-source-id: fe9b4ba3d08e910b60225d3ed6b17a314655dfe4
@jmccl jmccl linked a pull request Oct 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compiliation if glog >= 0.7 jmccl/folly
2 participants
@nh2 @chenrui333