Minor fixes in Futures.md #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvalue-qualified then() has been deprecated lvalue-qualified get() has been deleted
There was a problem hiding this comment.
yfeldblum has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
sandraiser
pushed a commit
to sandraiser/folly
that referenced
this pull request
Mar 4, 2019
Summary: lvalue-qualified then() has been deprecated lvalue-qualified get() has been deleted Pull Request resolved: facebook#911 Reviewed By: LeeHowes Differential Revision: D9310836 Pulled By: yfeldblum fbshipit-source-id: 662596bf5985f7ceabb2a23725d51f8e05407340
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 12, 2022
Summary: X-link: rsocket/rsocket-cpp#911 X-link: facebookexperimental/rust-shed#32 X-link: facebookincubator/reindeer#3 X-link: https://github.com/fairinternal/AIRStore/pull/36 X-link: facebookincubator/velox#1197 X-link: facebook/mvfst#242 X-link: facebook/sapling#116 X-link: facebookincubator/fizz#75 X-link: facebookincubator/katran#157 X-link: facebook/watchman#1011 X-link: facebook/wangle#205 X-link: facebook/proxygen#401 X-link: facebook/openr#129 X-link: facebookarchive/fbzmq#35 X-link: facebook/fb303#26 X-link: facebookarchive/bistro#59 Pull Request resolved: #1734 X-link: facebook/fboss#113 Adds an environment variable to getdeps to provide `hg` info to avoid calling `hg` directly. When using `getdeps` inside a containerized environment (which we need to build Research Super Cluster tooling with the correct linker attributes), `getdeps` fails because of unregistered mercurial extensions in the `hgrc`. This allows `getdeps` to be useable in an environment where the mercurial extensions used in a project aren't installed/available. Reviewed By: vivekspai Differential Revision: D34732506 fbshipit-source-id: 6475088fbf3323347095ca5af8a902382cf8f9d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lvalue-qualified then() has been deprecated
lvalue-qualified get() has been deleted