feat: new downsample mode #2760
Conversation
|
@yungsters has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
imagepipeline/src/main/java/com/facebook/imagepipeline/core/ProducerFactory.java
Show resolved
Hide resolved
|
@sunnylqm has updated the pull request. You must reimport the pull request before landing. |
|
@yungsters has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@sunnylqm has updated the pull request. You must reimport the pull request before landing. |
|
@yungsters any more concerns? |
|
I'm currently waiting for a colleague to take a look, but they're currently on vacation. No concerns from me, but I'll report back as soon as we have progress. |
|
@yungsters merged this pull request in 0d78d83. |
|
@sunnylqm, this has been merged. Thanks again for advocating for this improvement and for contributing this pull request that takes into consideration backward compatibility! |
Motivation (required)
Introduce a new method,
setDownsampleMode(DownsampleMode), to allow downstream libraries to disable downsampling but not break other existing use cases. Fixes #2397Test Plan (required)
Test a large remote image like #2397 (comment)
With default config or set
downsampleModetoAUTO/ALWAYS, it should be downsampled/blurred like how it behaves today.Change it to
NEVERit should NOT be downsampled.