Promise.allSettled and Promise.any is undefined

[retyui]

That super weird that a fresh method from ES2022 Object.hasOwn was implemented, but methods of perv. ecmascript spec not implemented yet:

• Promise.allSettled(...) // ES2020
• Promise.any(...) // ES2021

Bug Description

• I have run gradle clean and confirmed this bug does not occur with JSC

Hermes version: 0.11.0
React Native version (if any): 0.69.0
OS version (if any): Android 11
Platform: arm64-v8a, armeabi-v7a, x86, x86_64

Steps To Reproduce

const object1 = {prop: 'exists'};

console.log(Object.hasOwn(object1, 'prop')); // true
console.log(Object.hasOwn(object1, 'toString')); // false

Promise.allSettled([]); // TypeError: undefined is not a function, js engine: hermes
Promise.any([]);        // TypeError: undefined is not a function, js engine: hermes

The Expected Behavior

// `Promise.allSettled, Promise.any` works without any exceptions

[SMKH-PRO]

Promise.allSettled is undefined in React-Native 0.68.2 with hermes enabled.

Any solution to this?

[retyui]

you need to install and apply custom polyfill for that methods

[ljharb]

eg https://npmjs.com/promise.any and https://npmjs.com/promise.allsettled

[retyui]

@SMKH-PRO also be careful with these polyfills

• promise.allsettled - 41.5kB
• promise.any - 48.9kB

As their size too big( 48.9kB is 7 React's (6.4kB)!!!

it's better to use something lighter

[ljharb]

@retyui theres nothing lighter that’s also correct, and correctness is much more important. Also, you’re using sizes from bundlephobia, which is FUD because in an actual application it won’t be anywhere near that large.

[retyui]

theres nothing lighter

actually no, for example 25 lines pollyfill for Promise.allSettled()

---

Note: React Native use then/promise

https://github.com/facebook/react-native/blob/080a5921e158dee8b2edc93d56232ba0517d831a/Libraries/Promise.js#L13-L23

[ljharb]

@retyui and those 25 lines are incorrect, per spec. They also break if delete Promise.all has been ran, which is also incorrect.

This thread isn't the place to debate it, though.

[retyui]

• Promise.allSettled - added (0.68.4, v0.69.6, 0.70.x+)Add support Promise.allSettled out of box react-native#34544
• Promise.any - I hope will be added soon Add support Promise.any out of box react-native#35080

[retyui]

Re open issue:

reason: facebook/react-native#35363 (comment)

[fbmal7]

So, a bit of context for how we handle Promise. We actually do use a modified version of a polyfill, based on this implementation. So, Hermes actually has had support for allSettled and any.

• allSettled was introduced here, Sep 7th.
• any was introduced here, Oct 27th.

So, this does make sense that they have not made their way into the most recent versions of RN, at least specifically for any. However, allSettled may have had a chance to make it in.. Let me see if I can find the cut dates for the recent releases.

[fbmal7]

@retyui So to follow up, this behavior you are experiencing is expected for the version you are using. RN 0.70 was first cut on Jul 15th. RN 0.71 is not fully released yet, but the first release candidate was cut on Nov 3rd.

Therefore, you can expect Promise.allSettled and Promise.any for RN 0.71+, and not in any version below. At least, this is purely from the Hermes' side of things. I'm not sure if there are any additional polyfills that RN includes when Hermes is present that could add support for these methods in other versions, but that would be question for RN.

[retyui]

got it, should be fixed in react-native@0.71.x

[n-kulic]

got it, should be fixed in react-native@0.71.x

I have tested with "react-native": "0.70.6" (hermes enabled) on Android physical device (Samsung Galaxy s9) and it appears that allSettled is still undefined as I'm getting that error

Promise.allSettled([])

-[TypeError: undefined is not a function]

[neildhar]

@n-kulic as mentioned above, this feature is available in RN versions 0.71 and newer. Version 0.70.6 is older than the minimum version that supports this feature.

[leeyyl]

@neildhar No it's wrong because I use RN 0.71.7 and I got the same issue as @n-kulic said.

[tmikov]

@leeyyl as you can see here

hermes/lib/InternalBytecode/01-Promise.js

Line 331 in eaf662b

core.allSettled = function (iterable) {

it is present in Hermes. According to the Git blame it was added here e8fa813 on Sep 7th 2022.

[leeyyl]

@leeyyl as you can see here

hermes/lib/InternalBytecode/01-Promise.js

Line 331 in eaf662b

core.allSettled = function (iterable) {

it is present in Hermes. According to the Git blame it was added here e8fa813 on Sep 7th 2022.

@tmikov So how to use the core.allSettled in Hermes? Because now I call Promise.allSettled still receive

-[TypeError: undefined is not a function]

[tmikov]

@leeyyl As I explained, Promise.allSettled has been available in Hermes since September 2022. Download any version of Hermes, compile and run the CLI and see for yourself.

Which version of Hermes is packaged with each RN release is an orthogonal question. You might be using a version of RN without it, or there might be a polyfill that is overwriting Promise, or something else could be wrong in your setup.

We are unable to investigate problems that are outside of Hermes, so consider filing an issue with React Native. They might know what is going on, might be able to pick this change in one of their point releases, etc.