Revert "Disable DateTimeFormat::formatToParts for Apple platform (#1155)" #1567
+98
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/revert-intl
branch
from
ceaea5d
to
86bc065
Compare
|
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
cipolleschi
force-pushed
the
cipolleschi/revert-intl
branch
from
86bc065
to
439aadb
Compare
|
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
cipolleschi/revert-intl
branch
from
439aadb
to
cb6ecca
Compare
|
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
…)" This reverts commit c5a633f.
cipolleschi
force-pushed
the
cipolleschi/revert-intl
branch
from
cb6ecca
to
355f514
Compare
|
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit c5a633f.
That commit removed the Intl.DateTimeFormat.formatToParts for Apple platforms from Hermes.
However, the community started depending on it, and we ended up manually reverting that commit in the release branch for the past 3 releases.
This is like reverting the commit in main, so we are proceeding with that approach to simplify the release process of React Native and Hermes to the OSS.
Test Plan
CI