Skip to content

Commit

Permalink
Minor fixes
Browse files Browse the repository at this point in the history
Summary: Just few minor fixes

Reviewed By: rmakheja

Differential Revision: D63149290

fbshipit-source-id: b25b35003ff592029a967ed04d350c76388d2a12
  • Loading branch information
yoney authored and facebook-github-bot committed Sep 20, 2024
1 parent ddcc7e8 commit f8da2fa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1571,8 +1571,9 @@ def test_exception_deepcopy(self) -> None:
# details) and verify that it doesn't affect `e`.
e_clone.unqualified_list_i32.append(4)
self.assertNotEqual(e.unqualified_list_i32, e_clone.unqualified_list_i32)
# pyre-ignore[16]: Fixme: type error to be addressed later
e_clone.optional_list_i32.append(4)
if e_clone.optional_list_i32 is not None:
e_clone.optional_list_i32.append(4)

self.assertNotEqual(e.optional_list_i32, e_clone.optional_list_i32)

self.assertEqual(e.unqualified_set_string, e_clone.unqualified_set_string)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,7 @@ def test_to_mutable_python(self) -> None:
union_mutable = TestUnionMutable(string_field="hello")
self.assertIs(union_mutable, union_mutable._to_mutable_python())

def test_serialize_not_implemented_yet(self) -> None:
def test_serialize(self) -> None:
mutable_serializer.serialize(TestUnionMutable())

with self.assertRaisesRegex(Exception, "underflow"):
Expand Down

0 comments on commit f8da2fa

Please sign in to comment.