Fix highlight_string function for proper highlighting - #3160 #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 11, 2014 15:48
(#3160) During the highlighting process, the token is inspected to check whether or not it is a double-quote ("). If it is, the `$next_color` variable is set to `$colors['string']`.
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D24789 |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
added 7 commits
October 12, 2014 10:31
The 'defaultText' field inside the 'info' array of a ReflectionParameter instance is matched against a regex that checks if it complies with the accepted format for labels and constants names. Then it checks whether or not it is one of the following reserved words: 'NULL', 'false' and 'true'. If it is, then the function returns FALSE. Otherwise, TRUE.
…hod from the ReflectionParameter class.
if the token is a string.
…tant method from the ReflectionParameter class." This reverts commit 017a780.
This reverts commit b442e9d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #3160.