Trivial tweaks #7019
Closed
Trivial tweaks #7019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D57153 |
1 similar comment
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D57153 |
|
This seems to have dropped all of the summaries from the doc comments, could we not do that? |
|
Initially I saw most functions without them, so for consistency I've also removed some. My goal was to get sane IDE support, comments are available in PHP docs anyway, but it is handy to have arguments types in source code. Should I bring them back? |
|
If the summaries were already there, as is the case here, keep them. |
Some arguments renamed as they are in PHP docs. `UnexpectedValueException` is used instead of `PharException` in Phar constructor as defined in PHP docs. No code logic changes.
nazar-pc
force-pushed
the
phar-compression-trivial-tweaks
branch
from
9ae370d to
3992311
Compare
|
Restored what was already present |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for landing support for compressed Phar files.
As discussed in #4263 changes that doesn't affect code logic separated for easier review.
This PR primarily includes manual edits of PhpDoc sections to conform with arguments names from PHP documentation and to make them understandable to IDE. Also some Exceptions classes changed as it is defined in PHP docs.