Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin OpenSSL version to 1.1 #9208

Closed
wants to merge 5 commits into from
Closed

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Sep 17, 2022

#9184 fails because recently nixpkgs unstable changes the default OpenSSL version to 3.0, which is not compatible with Folly.

This PR pins OpenSSL version to 1.1 to suppress the error.

Test Plan:
GitHub Actions should pass

@facebook-github-bot
Copy link
Contributor

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@henryr
Copy link

henryr commented Sep 17, 2022

We're interested in using OpenSSL 3.0 on 22.04 - do you anticipate keeping this pin for a while, or is it a temporary change?

@Atry
Copy link
Contributor Author

Atry commented Sep 19, 2022

  1. This PR pins OpenSSL version of nix packages, not for packages from the Ubuntu distribution.
  2. We HHVM maintainers cannot support OpenSSL 3.0 right now, because Folly, a HHVM's dependency, has not supported OpenSSL 3.0 yet.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@Atry has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Atry Atry deleted the nix-flake-update/master branch September 21, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants