Fix AndroidManifest.xml due to missing minSDK and missing export prop…

…erties in OpenGL / Vulkan sample apps Reviewed By: corporateshark Differential Revision: D68680042 fbshipit-source-id: 33eb8a81afff379ffb1d48b82f66529e481c8929
facebook · Jan 28, 2025 · 69c6a7a · 69c6a7a
1 parent c6b101f
commit 69c6a7a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/samples/android/opengl/java/com/facebook/igl/sample/AndroidManifest.xml b/samples/android/opengl/java/com/facebook/igl/sample/AndroidManifest.xml
@@ -2,6 +2,7 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
           package="com.facebook.igl.sample.opengl">
   <uses-feature android:glEsVersion="0x00030000"/>
+  <uses-sdk android:minSdkVersion="24" android:targetSdkVersion="35"/>
   <application
       android:allowBackup="false"
       android:fullBackupContent="false"
@@ -10,7 +11,8 @@
     <activity android:name="SampleActivity"
               android:theme="@android:style/Theme.NoTitleBar.Fullscreen"
               android:launchMode="singleTask"
-              android:configChanges="orientation|keyboardHidden">
+              android:configChanges="orientation|keyboardHidden"
+              android:exported="true">
       <intent-filter>
         <action android:name="android.intent.action.MAIN" />
         <category android:name="android.intent.category.LAUNCHER" />

diff --git a/samples/android/vulkan/java/com/facebook/igl/sample/AndroidManifest.xml b/samples/android/vulkan/java/com/facebook/igl/sample/AndroidManifest.xml
@@ -2,6 +2,7 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
           package="com.facebook.igl.sample.vulkan">
   <uses-feature android:glEsVersion="0x00030000"/>
+  <uses-sdk android:minSdkVersion="24" android:targetSdkVersion="35"/>
   <application
       android:allowBackup="false"
       android:fullBackupContent="false"
@@ -10,7 +11,8 @@
     <activity android:name="SampleActivity"
               android:theme="@android:style/Theme.NoTitleBar.Fullscreen"
               android:launchMode="singleTask"
-              android:configChanges="orientation|keyboardHidden">
+              android:configChanges="orientation|keyboardHidden"
+              android:exported="true">
       <!-- Tell NativeActivity the name of the .so -->
 			<meta-data android:name="android.app.lib_name" android:value="sampleVulkan" />
 			<!-- This filter lets the apk show up as a launchable icon. -->