Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【igl nanovg part-1】Android : add seperate nanovg sample project #218

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

【igl nanovg part-1】Android : add seperate nanovg sample project #218

wants to merge 12 commits into from

Conversation

vinsentli
Copy link
Contributor

@vinsentli vinsentli commented Nov 27, 2024 •
edited
Loading

This is a prerequisite pull request for igl nanovg(#213).

@vinsentli vinsentli changed the title android : copy assets file to '/data/data/com.facebook.igl.shell/files/' directory. 【igl nanovg part-2】android : copy assets file to '/data/data/com.facebook.igl.shell/files/' directory. Nov 27, 2024
@corporateshark corporateshark requested a review from rokuz November 27, 2024 19:28
corporateshark
corporateshark requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@corporateshark corporateshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a separate NanoVG sample which does this. We cannot change SampleActivity.java like that.

@vinsentli
Copy link
Contributor Author

vinsentli commented Nov 29, 2024 •
edited
Loading

This is a general operation,not only for nanovg sample.
So we can use fopen() to access file,instead of only restricted by using Assets_open() on android.

@corporateshark
Copy link
Contributor

This is a general operation,not only for nanovg sample. So we can use fopen() to access file,instead of only restricted by using Assets_open() on android.

All existing samples do not require this behavior and we do not want to touch the SD card like that.

@vinsentli vinsentli marked this pull request as draft December 16, 2024 04:05
@vinsentli vinsentli changed the title 【igl nanovg part-2】android : copy assets file to '/data/data/com.facebook.igl.shell/files/' directory. 【igl nanovg part-4】android : copy assets file to '/data/data/com.facebook.igl.shell/files/' directory. Dec 18, 2024
@vinsentli vinsentli changed the title 【igl nanovg part-4】android : copy assets file to '/data/data/com.facebook.igl.shell/files/' directory. 【igl nanovg part-1】Android : Add NanovgSample project Dec 22, 2024
@vinsentli vinsentli changed the title 【igl nanovg part-1】Android : Add NanovgSample project 【igl nanovg part-1】Android : add seperate nanovg sample project Dec 22, 2024
@vinsentli vinsentli marked this pull request as ready for review December 22, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokuz rokuz Awaiting requested review from rokuz

@corporateshark corporateshark Awaiting requested review from corporateshark

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinsentli @corporateshark @facebook-github-bot