Return exit code 1 if coverage threshold requirements are not met on jest@20.0.0

[honzabrecka]

Whenever the --coverage flag is passed, jest exits with 0 even if the threshold requirements are not met, but it should return non-zero exit code.

Worked before upgrade to jest@20.0.0.

[thymikee]

Cannot repro, fails with exit code 1 for 3 different projects. Have you tried purging node_modules?

[FQ400]

I have the same issue. Downgrading from 20.0.0 to 19.0.2 fixed it.

[andreffvalente]

@thymikee You should reproduce the issue by setting the collectCoverageFrom in your Jest configuration. That forces the reporter to collect the coverage from untested files.

The Coverage reporter will not return a resolved promise when collectCoverageFrom matches files and consequently the Dispatcher will resolve the onRunComplete promise before collecting the result from reporter.

[thymikee]

cc @DmitriiAbramov

[jamsea]

I'm having the same issue, the merged PR doesn't seem to have fixed this for me. I'm going to do some more poking around

[jamsea]

Just a follow up in case anyone is brought here by Google:

Removing the projects node in jest.config.json fixed the issue. I also had to add:

  "resolutions": {
    "jest": "^21.2.1"
  }

To package.json (I'm using yarn), to make sure I was using the right version of jest.

I'll take a deeper look why removing projects fixed this. Guessing it's a similar issue with a race condition.

[akougblenou]

I don't have the projects node in my config but I still can get the coverage threshold to do it job, it is still returning an exit code of 0.

[Sufiane]

I still have this issue with jest@23.4.1.

Do I need to open a new issue?

[rickhanlonii]

@Sufiane yes, please open a new issue if you have a reproduction on the latest Jest version 👌

[Sufiane]

@rickhanlonii thanks for the response, i have done so. You can find the new issue here: #7450

[victorwads]

#6434 (comment)

I am using react-native-testing-library and what resolved this error for me was to simply make the callback of the test case async like

it('your test case', () => {...})

becomes:

it('your test case', async () => {...})

This worked for me, using react tests

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.