Return exit code 1 if coverage threshold requirements are not met

[lazywithclass]

First of all thanks for this tool!

I'm very new to Jest so please forgive any stupid error or incorrect assumption.
I'm very open to adapt this to the project / community needs, in fact I am trying to understand how to add an integration test for this, any suggestion is more than welcome.

Summary

Whenever the --coverage flag is passed, jest exits with 0 even if the threshold requirements are not met.

Seems like the solution is to determine if a run is successful after onRunComplete is called, because in that function aggregatedResults is populated with the required values.

Test plan

I've written a small POC which has a 100% coverage requirement which is not met.
With the change after you run npm test in this POC you will get 1 as a result from echo $?.

// sum.js
module.exports = (a, b) => a + b;

// __tests__/sum.test.js
test('adds1 +2 to equal3', () => {
  const sum = require('../sum');
  expect(42).toBe(41+1);
});

// package.json
{
  "name": "jest-example",
  "scripts": {
    "test": "/usr/local/lib/node_modules/jest/jest --coverage"
  },
  "jest": {
    "coverageThreshold": {
      "global": {
        "branches": 100,
        "functions": 100,
        "lines": 100,
        "statements": 100
      }
    }
  },
  "devDependencies": {
    "jest": "^16.0.2"
  }
}

[facebook-github-bot]

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[codecov-io]

Current coverage is 87.77% (diff: 100%)

Merging #1974 into master will not change coverage

@@             master      #1974   diff @@
==========================================
  Files            38         38          
  Lines          1252       1252          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1099       1099          
  Misses          153        153          
  Partials          0          0          

Powered by Codecov. Last update 891ee5a...732d48f

[cpojer]

thank you!

[honzabrecka]

Seems to be broken after upgrade to 20.0.0.

[cpojer]

@honzabrecka mind opening a new issue?

[honzabrecka]

@cpojer No problem, here it is #3520

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.