Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to typescript-eslint@3 and eslint@7 #10437

Merged
merged 4 commits into from
Aug 23, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 23, 2020

Summary

Relates to #10177, but disables some defaults from the ban-types rule. @G-Rath is currently working on them (thanks! 🙏), but we can bump the other stuff in the meantime.

Test plan

Green CI

@SimenB SimenB changed the title chore: bump to typescript-eslint@3 chore: bump to typescript-eslint@3 and eslint@7 Aug 23, 2020
Copy link
Contributor

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is the best way to go 😅

If we wanted to make those warn, we could use a local plugin that just re-exports ban-types to duplicate it under a new name.
(tbh that wouldn't be the worst solution for eslint-plugins to do as a general pattern for these sorts of rules: ship a ban-*-1 & ban-*-2 🤔)

@SimenB
Copy link
Member Author

SimenB commented Aug 23, 2020

As a migrating strategy? I kinda like that idea 😀 In this case we can hopefully turn them on again pretty soon, though. Could possibly disable only per module via some more specific overrides config instead of for all files as well, not sure if it's worth the trouble or not, though.

@G-Rath
Copy link
Contributor

G-Rath commented Aug 23, 2020

Yeah exactly! Give me 5 and I'll whip something up in another PR (since it can be landed without this)

@SimenB
Copy link
Member Author

SimenB commented Aug 23, 2020

It's 3 am here, so I'll head to bed very soon. Happy to take a look tomorrow, though 😀

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants