Do not reset global.document before CustomElement:disconnectedCallbac…

[dalvarezmartinez1]

Summary

The order of the statements inside of the teardown function was changed.
This is due to document not being available in the disconnectedCallback function of CustomElements.

The stack trace looks something like this:
this.global.close(); -> window.js::close -> Element.js::innerHTML -> custom-elements.js::ceReactionsPostSteps -> custom-elements.js::invokeCEReactions -> Function.js::invokeTheCallbackFunction -> my-element::disconnectedCallback

Afaik, the document should be available inside of disconnectedCallback, if it's not this results in a:
"Error: Uncaught [TypeError: Cannot read property 'dispatchEvent' of null]"

Test plan

I ran yarn build and yarn test. Something weird: during the yarn test, it was written 1 test failed but at the end all succeeded.

[codecov-commenter]

Codecov Report

Merging #11871 (c6d4dd1) into main (d7f0975) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #11871   +/-   ##
=======================================
  Coverage   68.93%   68.93%           
=======================================
  Files         312      312           
  Lines       16412    16412           
  Branches     4760     4760           
=======================================
  Hits        11314    11314           
  Misses       5071     5071           
  Partials       27       27           

Impacted Files	Coverage Δ
packages/jest-environment-jsdom/src/index.ts	42.85% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f0975...c6d4dd1. Read the comment docs.

[SimenB]

@dalvarezmartinez1 Thanks for sending a PR! Could you add a test that fails without this change and a changelog entry? 🙂

[SimenB]

@dalvarezmartinez1 ping 🙂

[dalvarezmartinez1]

It's on my list, I've been crazy busy lately, please don't close it, I will eventually do it

[dalvarezmartinez1]

@SimenB added test and changelog entry

[SimenB]

Thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.