Do not reset global.document before CustomElement:disconnectedCallbac… #11871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The order of the statements inside of the teardown function was changed.
This is due to document not being available in the disconnectedCallback function of CustomElements.
The stack trace looks something like this:
this.global.close(); -> window.js::close -> Element.js::innerHTML -> custom-elements.js::ceReactionsPostSteps -> custom-elements.js::invokeCEReactions -> Function.js::invokeTheCallbackFunction -> my-element::disconnectedCallback
Afaik, the document should be available inside of disconnectedCallback, if it's not this results in a:
"Error: Uncaught [TypeError: Cannot read property 'dispatchEvent' of null]"
Test plan
I ran yarn build and yarn test. Something weird: during the yarn test, it was written 1 test failed but at the end all succeeded.