fix: add option to disable worker_threads
in jest-worker
#7681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are certain issues around
worker_threads
(notably missingprocess.umask
, which makes a few dependencies throw). While these issues are getting fixed (npm/write-file-atomic#37 & nodejs/node#25526) I think we should be on the safe side with Jest 24 and wait for the dust to settle before using it in Jest.However, the default behavior is still to use it if available, this PR explicitly disables it in the places we use
jest-worker
internally.EDIT: Follow-up making it opt-in: #7693
Test plan
Unit test added. This should also fix CI for node 11.