support running inside of a worker thread #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Jan 22, 2019
addaleax
reviewed
Jan 22, 2019
addaleax
approved these changes
Jan 22, 2019
|
This seems pretty reasonable to me, I'll look about landing this today! |
|
This is landed and been released in 2.4.0! |
|
Awesome, thank you very much @iarna! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋
Jest uses this module to write cached files to disk from within workers. It works great with
child_process.spawn, but it doesn't work from withinworker_threadsdue toprocess.pidbeing shared between the main thread and all its workers.This PR will check if it's being run from within a worker, and if so, use
worker_threads.threadId, which should be unique.I've put together an example over in jestjs/jest#7680 whch shows
process.pidbeing identical. We're super close to a release, so for now I've just copied over the source from this project into our own module - would love for you to merge this (or otherwise fix it), though! 🙂