Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow returning a Promise? #210

Closed
ianwremmel opened this issue Jul 16, 2017 · 4 comments
Closed

Allow returning a Promise? #210

ianwremmel opened this issue Jul 16, 2017 · 4 comments

Comments

@ianwremmel
Copy link

I'm trying to write a codemod that opens tickets for each TODO or FIXME in my code and updates the in-code comments to include the link to the ticket. As far as I can tell, that's currently impossible given jscodemod's API is synchronous.

Is there a way to do this now? If not, would you be open to a PR that allows the transform function to return a Promise?

rektide added a commit to rektide/jscodeshift-async that referenced this issue Feb 6, 2018
@ngryman
Copy link

ngryman commented May 13, 2019

👆It seems that this issue has been resolved and should be closed.

@fkling
Copy link
Contributor

fkling commented Jun 5, 2019

@ngryman: It's not resolved, that commit points to a different repo.

@mstruensee
Copy link

will this be a new feature? or not a desired feature to have?

@Daniel15
Copy link
Member

This is now available in 0.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants