Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "license" field to package.json #384

Closed
martinsuchan opened this issue Jul 27, 2020 · 2 comments
Closed

Add "license" field to package.json #384

martinsuchan opened this issue Jul 27, 2020 · 2 comments

Comments

@martinsuchan
Copy link
Contributor

The npm page does not show License for the npmcodeshift package, see: https://www.npmjs.com/package/jscodeshift
This is causing issues in our internal enterprise package proxy that is blocking any packages without valid whitelisted license type.
I'm not sure if this field in npm repository needs to be filled manually or it's taken from the github source code, but it should be possible to fix it by adding the "license": "MIT" field into the package.json file.

Affected version: 0.10.0
Current behavior: npm page does not show any license for this project. package.json does not have "license" field.
Expected behavior: show MIT license on NPM site. Add "license": "MIT" to package.json

image

@gkz gkz closed this as completed in 3dc9fba Sep 2, 2020
gkz added a commit that referenced this issue Sep 2, 2020
Added "license" field to package.json. Fixes #384
@martinsuchan
Copy link
Contributor Author

Note the npmjs.com page still does not show the license field for this package.
The maintainer of this package should probably check and fix this most likely one-liner issue:
https://www.npmjs.com/package/jscodeshift

@gkz
Copy link
Member

gkz commented Sep 8, 2020

It will be fixed the next time a version is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants